Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to put back previously flakey addmul tests #55775

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Try to put back previously flakey addmul tests #55775

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a6ca44
Try to put back previously flakey addmul tests
LilithHafner Sep 14, 2024
1bfa5ca
Only run the tests once instead of 100x
LilithHafner Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions stdlib/LinearAlgebra/test/addmul.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ end
Bc = Matrix(B)
returned_mat = mul!(C, A, B, α, β)
@test returned_mat === C
# This test is skipped because it is flakey, but should be fixed and put back (see #49966)
@test_skip collect(returned_mat) ≈ α * Ac * Bc + β * Cc rtol=rtol
@test collect(returned_mat) ≈ α * Ac * Bc + β * Cc rtol=rtol

y = C[:, 1]
x = B[:, 1]
Expand All @@ -190,8 +189,7 @@ end

returned_mat = mul!(C, Af, Bf, α, β)
@test returned_mat === C
# This test is skipped because it is flakey, but should be fixed and put back (see #49966)
@test_skip collect(returned_mat) ≈ α * Ac * Bc + β * Cc rtol=rtol
@test collect(returned_mat) ≈ α * Ac * Bc + β * Cc rtol=rtol
end
end
end
Expand All @@ -203,8 +201,7 @@ end
Bc = Matrix(B)
returned_mat = mul!(C, A, B, α, zero(eltype(C)))
@test returned_mat === C
# This test is skipped because it is flakey, but should be fixed and put back (see #49966)
@test_skip collect(returned_mat) ≈ α * Ac * Bc rtol=rtol
@test collect(returned_mat) ≈ α * Ac * Bc rtol=rtol
end
end

Expand Down