Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] fix GC race bug in pool sweep #55485

Merged

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Aug 13, 2024

We have parallel sweeping on 1.11, so we should use atomics here.

This issue has already been fixed on master due to #54961.

We can also backport #54961 to release-1.11, but I have some preference to land this one since it's considerably less disruptive and we're already on RC2.

@d-netto d-netto added GC Garbage collector bugfix This change fixes an existing bug labels Aug 13, 2024
@d-netto d-netto requested a review from gbaraldi August 13, 2024 16:48
@d-netto d-netto force-pushed the dcn-fix-gc-race-bug-in-pool-sweep branch from b46f879 to a0fafc3 Compare August 13, 2024 16:53
@KristofferC
Copy link
Member

Generally better to do backports against the latest backport PR (#55344) because then it will go through PkgEval etc.

@vtjnash vtjnash changed the base branch from release-1.11 to backports-release-1.11 August 14, 2024 16:11
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Aug 14, 2024
@oscardssmith oscardssmith merged commit bcb33ed into backports-release-1.11 Aug 14, 2024
8 checks passed
@oscardssmith oscardssmith deleted the dcn-fix-gc-race-bug-in-pool-sweep branch August 14, 2024 19:11
@oscardssmith oscardssmith removed the merge me PR is reviewed. Merge when all tests are passing label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug GC Garbage collector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants