Restore cmdlineargs tests on non-Windows platforms #55368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
multithreading
These tests have been flaky for some time, but should be working better now.
giordano
force-pushed
the
mg/test-cmdlineargs
branch
from
cc6b988 to
3c4425b
Compare
|
I stress tested this PR by running the test ten times over a few days, and the errors reported in #46537 and #49154 didn't show up at any point (there were other intermittent failures, but not the ones in cmdlineargs). It sounds like the underlying issue was indeed fixed, as suggested by #46537 (comment). |
DilumAluthge
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests have been flaky for some time (#46537, #49154) and were skipped in #50071, but should be working better now according to #46537 (comment).