Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't throw EOFError from sleep #54955

Merged
merged 2 commits into from
Jul 17, 2024
Merged

don't throw EOFError from sleep #54955

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54322d5
don't throw EOFError from sleep
lgeissbauer-btig Jun 27, 2024
4f978db
add acquire/release ordering
vtjnash Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions base/asyncevent.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,11 @@ function _trywait(t::Union{Timer, AsyncCondition})
t isa Timer || Core.Intrinsics.atomic_fence(:acquire_release)
else
if !isopen(t)
vtjnash marked this conversation as resolved.
Show resolved Hide resolved
close(t) # wait for the close to complete
return false
set = t.set
if !set
close(t) # wait for the close to complete
return false
end
end
iolock_begin()
set = t.set
Expand Down