Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing methods for UniformScaling #53949

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Apr 4, 2024

The methods float, cis, sincos and sincosd are defined for matrices, so it makes sense for these to be defined for a UniformScaling as well.
E.g.:

julia> float(2I)
UniformScaling{Float64}
2.0*I

julia> sincos(2I)
(UniformScaling{Float64}(0.9092974268256817), UniformScaling{Float64}(-0.4161468365471424))

@jishnub jishnub added the linear algebra Linear algebra label Apr 4, 2024
@jishnub jishnub merged commit e64fa86 into master Apr 5, 2024
9 checks passed
@jishnub jishnub deleted the jishnub/missingmethodsuniformscaling branch April 5, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants