Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ScopedValues for TestSets #53462

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

use ScopedValues for TestSets #53462

wants to merge 11 commits into from

Conversation

simonbyrne
Copy link
Contributor

Another attempt at #51012

@simonbyrne simonbyrne force-pushed the sb/test-scope branch 6 times, most recently from 1c67443 to b1fec32 Compare February 27, 2024 05:38
@simonbyrne
Copy link
Contributor Author

@vchuravy @Keno I'm getting some weird failures on this branch originating from this line:

@assert current_mapping == val

The simplest reproducer I have is:

using Test
@testset begin
    @testset for r in Int[1]
    end
end

@simonbyrne
Copy link
Contributor Author

Blocked by #53521

@nickrobinson251
Copy link
Contributor

Would love to see this merged!

@simonbyrne do you have any time to work on this? I'd be happy to rebase and help get it over the line. I think rebasing, and then deciding what to do with the commented-out scope tests might be all that's needed here?

@giordano giordano added testsystem The unit testing framework and Test stdlib stdlib Julia's standard library labels Sep 23, 2024
stdlib/Test/src/Test.jl Outdated Show resolved Hide resolved
@giordano
Copy link
Contributor

I initially thought I managed to badly botch the rebase, but I believe this is now failing to build because after the rebase #55452 was merged in and that PR removed using .ScopedValues inside Base, so imports need to change a little bit. I'll leave this exercise to someone else 😁

@simonbyrne
Copy link
Contributor Author

Sorry, it still needs some work. The handling of errors is wasn't quite correct, and the resetting of rng state is kind of confusing (arguably should be handled differently)

@simonbyrne simonbyrne marked this pull request as ready for review October 5, 2024 03:51
@simonbyrne
Copy link
Contributor Author

Currently blocked by #56062

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Julia's standard library testsystem The unit testing framework and Test stdlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants