-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test to avoid #53054 regressions #53079
Conversation
Should this ideally be a test in openblas? It somehow feels excessive if we should test bugs of dependencies here. |
I also thought so initially, but seeing there was just a lone test in there I thought it might be reserved for other things. But yeah, let me move it. |
So, @giordano argues here that "I don't think this test should be here, this is meant to test only very basic functionalities of the jll, like opening the library and such. If we ever switch to a different default blas backend, the test would still be useful, it isn't specific to openblas." |
This reverts commit f4ae412.
@pablosanjose I think the |
Sorry about that, I'll try to fix it |
Eh, I mean, it's not like we run every test a million times like this does to test "deterministic behavior". With "should this ideally be a test in openblas" I meant that they shouldn't be in this repo at all but be tested upstream in openblas itself to prevent the regression at the earliest stage possible. |
Oh, I fully appreciate the point of Kirstoffer. When it doesn't fail, this test takes a full 0.15s on my machine. Maybe it is too excessive? The problem is that a lower number of iterations made it fail too infrequently to be useful. And of course his other argument that this would be more useful upstream is also totally clear. What do you think @giordano? If you guys agree this is too much overhead for a test that is likely never going to fail again, please do use your authority to revert this PR. |
Tests issue JuliaLang/LinearAlgebra.jl#1051. The same test is included in backport #53074.