Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: load jl_n_threads in jl_gc_pool_live_bytes #52034

Merged
merged 1 commit into from
Nov 6, 2023
Merged

bugfix: load jl_n_threads in jl_gc_pool_live_bytes #52034

merged 1 commit into from
Nov 6, 2023

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Nov 5, 2023

Otherwise we may just observe gc_n_threads = 0 (jl_gc_collect sets it to 0 in the very end of its body) and this function becomes a no-op.

@d-netto d-netto added GC Garbage collector bugfix This change fixes an existing bug labels Nov 5, 2023
vchuravy
vchuravy approved these changes Nov 5, 2023
View reviewed changes
src/gc.c Outdated Show resolved Hide resolved
@d-netto d-netto changed the title bugfix: update gc_n_threads in jl_gc_pool_live_bytes bugfix: load jl_n_threads in jl_gc_pool_live_bytes Nov 5, 2023
vchuravy
vchuravy approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think my question was also a it larger. Why are those globals to begin with?

@d-netto d-netto merged commit d834a44 into master Nov 6, 2023
6 of 8 checks passed
@d-netto d-netto deleted the dcn-pool-live-bytes branch November 6, 2023 10:56
d-netto added a commit to RelationalAI/julia that referenced this pull request Nov 6, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
4109fd7 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
@d-netto d-netto mentioned this pull request Nov 6, 2023
Merged
3 tasks
d-netto added a commit to RelationalAI/julia that referenced this pull request Nov 6, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034) (#…
dffb365 
…106)

Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Nov 16, 2023
@d-netto @kpamnany
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
6dc060e 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Nov 16, 2023
@d-netto @kpamnany
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
4869e06 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
d-netto added a commit to RelationalAI/julia that referenced this pull request Nov 28, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
fa049c8 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 29, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
09b5c1c 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Dec 3, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
8b82ce1 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Dec 4, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
4ec33fc 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
Drvi pushed a commit to RelationalAI/julia that referenced this pull request Dec 7, 2023
@d-netto @Drvi
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034) (#…
13effd9 
…106)

Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Dec 13, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
5357400 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Dec 17, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
127847a 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Dec 18, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
34a1a8e 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Dec 19, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
1e0d4a7 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Dec 23, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
3dc7db5 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Dec 24, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
afe777a 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Dec 25, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
22bba38 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Dec 26, 2023
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
d7742e8 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Jan 6, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
a1889b8 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
Drvi pushed a commit to RelationalAI/julia that referenced this pull request Jan 8, 2024
@d-netto @Drvi
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
8ef8ac1 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Jan 13, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
4e7a226 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Jan 18, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
d0d226b 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Jan 23, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
844a380 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Jan 24, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
7c6a0c8 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Jan 25, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
74c9e9b 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Jan 27, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
175a619 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Jan 30, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
d032622 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Jan 31, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
9cd06d1 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Feb 1, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
3863a81 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Feb 6, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
44afa9f 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Feb 7, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
eef0fa8 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Feb 14, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
d8584b1 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Feb 21, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
30fa9d9 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Feb 22, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
25a4822 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
Drvi pushed a commit to RelationalAI/julia that referenced this pull request Feb 28, 2024
@d-netto @Drvi
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
84e8daf 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Mar 1, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
66d02fe 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Mar 13, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
f85deae 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
d-netto added a commit that referenced this pull request Mar 16, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (#52034)
268ea2a 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
Drvi pushed a commit to RelationalAI/julia that referenced this pull request Apr 3, 2024
@d-netto @Drvi
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
a32eaeb 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
d-netto added a commit to RelationalAI/julia that referenced this pull request Apr 16, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
317e5e0 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Apr 23, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
718ec96 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Apr 24, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
3e1f00e 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Apr 30, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
39d7052 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Apr 30, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
fd23e40 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request May 2, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
309ca96 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request May 9, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
46fea06 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request May 19, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
5c7ede8 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request May 26, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
c0c0f14 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request May 28, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
f68acb2 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request May 29, 2024
@d-netto
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
9d62806 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
Drvi pushed a commit to RelationalAI/julia that referenced this pull request Jun 7, 2024
@d-netto @Drvi
bugfix: load jl_n_threads in jl_gc_pool_live_bytes (JuliaLang#52034)
2bf8a0c 
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets
it to 0 in the very end of its body) and this function becomes a no-op.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

@vchuravy vchuravy vchuravy approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug GC Garbage collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-netto @vchuravy @vtjnash