Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix _tryonce_download_from_cache (busybox.exe download error) #51531

Merged

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Sep 30, 2023

Removes what seems to be an intentional breakage that wasn't reverted before merge from #47015 which meant we've since never succeeded to use the cache.

Fixes

Got exception outside of a @test
--
  | LoadError: RequestError: HTTP/1.1 403 Forbidden while requesting https://frippery.org/files/busybox/busybox.exe
  | Stacktrace:
  | [1] #3
  | @ C:\buildkite-agent\builds\win2k22-amdci6-7\julialang\julia-master\julia-b90a992f06\share\julia\stdlib\v1.11\Downloads\src\Downloads.jl:270 [inlined]

This works

https://cache.julialang.org/https://frippery.org/files/busybox/busybox.exe

This does not

https://cache.julialang.org/foo/https://frippery.org/files/busybox/busybox.exe

@IanButterworth
Copy link
Member Author

Could we be hitting this download failure because upstream have started blocking our CI machines?
This works for me https://frippery.org/files/busybox/busybox.exe

@IanButterworth IanButterworth added backport 1.9 Change should be backported to release-1.9 backport 1.10 Change should be backported to the 1.10 release labels Sep 30, 2023
@DilumAluthge
Copy link
Member

Could we be hitting this download failure because upstream have started blocking our CI machines?

Yeah, that seems likely.

@DilumAluthge DilumAluthge added test This change adds or pertains to unit tests ci Continuous integration merge me PR is reviewed. Merge when all tests are passing labels Sep 30, 2023
@IanButterworth
Copy link
Member Author

I'm going to merge to get CI fixed as windows is passing and this is only on the windows code path

@IanButterworth IanButterworth merged commit ca862df into JuliaLang:master Sep 30, 2023
8 checks passed
@IanButterworth IanButterworth deleted the ib/fix_cache_downloads branch September 30, 2023 21:16
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Sep 30, 2023
@rmyorston
Copy link
Contributor

Could we be hitting this download failure because upstream have started blocking our CI machines?

Not knowingly, though it's possible the company hosting my website has taken action.

KristofferC pushed a commit that referenced this pull request Oct 3, 2023
@KristofferC KristofferC mentioned this pull request Oct 3, 2023
31 tasks
KristofferC pushed a commit that referenced this pull request Oct 11, 2023
KristofferC added a commit that referenced this pull request Nov 2, 2023
Backported PRs:
- [x] #50932 <!-- types: fix hash values of Vararg -->
- [x] #50975 <!-- Use rr-safe `nopl; rdtsc` sequence -->
- [x] #50989 <!-- fix incorrect results in `expm1(::Union{Float16,
Float32})` -->
- [x] #51284 <!-- Avoid infinite loop when doing SIGTRAP in arm64-apple
-->
- [x] #51332 <!-- Add s4 field to Xoshiro -->
- [x] #51397 <!-- call Pkg precompile hook in latest world -->
- [x] #51405 <!-- Remove fallback that assigns a module to inlined
frames. -->
- [x] #51491 <!-- Throw clearer ArgumentError for strip with two string
args -->
- [x] #51531 <!-- fix `_tryonce_download_from_cache` (busybox.exe
download error) -->
- [x] #51541 <!-- Fix string index error in tab completion code -->
- [x] #51530 <!-- Don't mark nonlocal symbols as hidden -->
- [x] #51557 <!-- Fix last startup & shutdown precompiles -->
- [x] #51512 <!-- avoid limiting Type{Any} to Type -->
- [x] #51595 <!-- reset `maxprobe` on `empty!` -->
- [x] #51582 <!-- Aggressive constprop in LinearAlgebra.wrap -->
- [x] #51592 <!-- correctly track element pointer in heap snapshot -->
- [x] #51326 <!-- complete false & true more generally as vals -->
- [x] #51376 <!-- make `hash(::Xoshiro)` compatible with `==` -->
- [x] #51557 <!-- Fix last startup & shutdown precompiles -->
- [x] #51845 
- [x] #51840 
- [x] #50663 <!-- Fix Expr(:loopinfo) codegen -->
- [x] #51863 <!-- LLVM 15.0.7-9 -->

Contains multiple commits, manual intervention needed:

- [ ] #51035 <!-- refactor GC scanning code to reflect jl_binding_t are
now first class -->
- [ ] #51092 <!-- inference: fix bad effects for recursion -->

Non-merged PRs with backport label:
- [ ] #51479 <!-- prevent code loading from lookin in the versioned
environment when building Julia -->
- [ ] #51414 <!-- improvements on GC scheduler shutdown -->
- [ ] #51366 <!-- Handle infix operators in REPL completion -->
- [ ] #50919 <!-- Code loading: do the "skipping mtime check for stdlib"
check regardless of the value of `ispath(f)` -->
- [ ] #50824 <!-- Add some aliasing warnings to docstrings for mutating
functions in Base -->
- [ ] #49805 <!-- Limit TimeType subtraction to AbstractDateTime -->
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Nov 2, 2023
nalimilan pushed a commit that referenced this pull request Nov 5, 2023
KristofferC added a commit that referenced this pull request Nov 7, 2023
Backported PRs:
- [x] #49357 <!-- Fix unclosed code fence in src/manual/methods.md -->
- [x] #50842 <!-- Avoid race conditions with recursive rm -->
- [x] #50858 <!-- Add a `threadpool` parameter to `Channel` constructor
-->
- [x] #50730 <!-- Fix integer overflow in `isapprox` -->
- [x] #50823 <!-- Make ranges more robust with unsigned indexes. -->
- [x] #50915 <!-- Add note the `Task` about sticky bit -->
- [x] #50989 <!-- fix incorrect results in `expm1(::Union{Float16,
Float32})` -->
- [x] #50912 <!-- Separate foreign threads into a :foreign threadpool
-->
- [x] #51019 <!-- fix a case of potentially use of undefined variable
when handling error in distributed message processing -->
- [x] #51222 <!-- Check again if the tty is open inside the IO lock -->
- [x] #51254 <!-- Ryu: make sure adding zeros does not overwrite
trailing dot -->
- [x] #51284 <!-- Avoid infinite loop when doing SIGTRAP in arm64-apple
-->
- [x] #51491 <!-- Throw clearer ArgumentError for strip with two string
args -->
- [x] #51531 <!-- fix `_tryonce_download_from_cache` (busybox.exe
download error) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.9 Change should be backported to release-1.9 ci Continuous integration test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants