-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few libgit2 improvements/fixes #51259
Conversation
yuyichao
commented
Sep 10, 2023
- 1.7.0 support.
- A few more operations on remote.
- Getting commit parents.
e9fe149
to
014ac86
Compare
If you change julia/stdlib/LibGit2_jll/Project.toml Line 3 in ad27e67
version = "1.7.1+0" and then run |
I did the test locally on 1.7.1 already. Do you want me to run the test on the CI? I haven't really done any extensive testing of the compatibility, just that tests passed and the functions I need myself works so I wasn't going to just bump the default version for everyone else... |
Yes, I think it'd be good to also upgrade the version of libgit2 we ship it julia, since we have the new build |
OK, sure. Added a new commit to bump the default version after roughly going through the libgit2 document to check if any other functions have any ABI breakage. |
d64caad
to
91d2836
Compare
Seems to actually crash in LibGit2 tests on 32-bit windows:
|
91d2836
to
0e89e31
Compare
There was indeed a missing ABI breaking change. The fetch options struct got an extra member I looked through the diff between the 1.7.0 and 1.6.4 header this time and I'm fairly sure there isn't anything missing anymore. OTOH, it seems that some of the constants (enums) aren't up to date. Most of the ones that are changed this time have missing updates from previous versions. I didn't check the enum values that didn't change in this version.. |
2e1001d
to
1350ca8
Compare
1350ca8
to
0251fbb
Compare
Updated for #51294 |
* Detached remote * Read remote reference advertisement list * Read remote default branch
Required for walking the commit graph.
0251fbb
to
7d51502
Compare