Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change heap-size-hint in test processes to total memory #50922

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Change heap-size-hint in test processes to total memory #50922

merged 1 commit into from
Aug 16, 2023

Conversation

gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented Aug 15, 2023 •
edited
Loading

It seems this is causing macos to hang because the shown free memory is generally very small.

This is a version of #50673

@gbaraldi gbaraldi force-pushed the gb/try-remove-heap-size branch from 58633a8 to 5e3fb41 Compare August 15, 2023 11:00
@gbaraldi gbaraldi changed the title Remove heap-size hint for test procs to test. Change heap-size-hint in test processes to total memory Aug 15, 2023
@gbaraldi gbaraldi added backport 1.10 Change should be backported to the 1.10 release GC Garbage collector labels Aug 15, 2023
@gbaraldi gbaraldi marked this pull request as ready for review August 15, 2023 11:03
@aviatesk aviatesk merged commit 883c19b into master Aug 16, 2023
@aviatesk aviatesk deleted the gb/try-remove-heap-size branch August 16, 2023 01:53
@IanButterworth IanButterworth mentioned this pull request Aug 19, 2023
Merged
58 tasks
@IanButterworth
Copy link
Member

This was in v1.10.0-beta2

@IanButterworth IanButterworth removed the backport 1.10 Change should be backported to the 1.10 release label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviatesk aviatesk aviatesk approved these changes

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
GC Garbage collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gbaraldi @IanButterworth @vtjnash @aviatesk