Define and export SubVector and SubMatrix aliases #50537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are the indices necessarily unitranges? |
No good reason. Fixed, thanks. |
|
I imagine we might also want |
baumgold
force-pushed
the
subvector
branch
2 times, most recently
from
ec646a5
to
c9c495f
Compare
|
It's unclear to me why the following test fails on x86_64-apple-darwin. @jishnub - any ideas? Thanks. Error During Test at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/julia-1dd6dbeea0/share/julia/test/abstractarray.jl:762
| Test threw exception
| Expression: #= /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-5.0/build/default-macmini-x64-5-0/julialang/julia-master/julia-1dd6dbeea0/share/julia/test/abstractarray.jl:762 =# @inferred(cat3v(As)) == zeros(2, 2, 2)
| return type Array{Float64, 3} does not match inferred return type Array{_A, 3} where _A |
|
That's a known issue, and unrelated to this PR #50550 |
|
Doctests need updating. |
Good catch, thanks. Done. |
|
My only hesitation here is that this changes printing and will cause some doctest churn throughout the ecosystem — will the nicety here be worth the extra collective effort it will entail? This search ( |
mbauman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubVectoris aSubArraywith dimensionality of 1