Extend ifelse lifting to regular SROA #50403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pre-existing bug, but was exposed by my improvements to SROA.
oscardssmith
added
bugfix
aviatesk
approved these changes
Jul 4, 2023
| field = try_compute_fieldidx_stmt(compact, stmt, struct_typ) | ||
| field === nothing && continue | ||
|
|
||
| leaves, visited_philikes = collect_leaves(compact, val, struct_typ, 𝕃ₒ) | ||
| leaves, visited_philikes = collect_leaves(compact, val, struct_typ, 𝕃ₒ, phi_or_ifelse_predecessors) |
There was a problem hiding this comment.
Now all callsites of collect_leaves use phi_or_ifelse_predecessors, so I think we can remove this argument entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only active for comparison lifting, but it is sensible for regular SROA also. While I was doing this I also found another oracle undercount bug (fixed here) as well as an overcount bug (#50312 (comment)).