Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocation Profiler: Types for all allocations #50337

Merged
merged 13 commits into from
Jul 31, 2023
Merged

Allocation Profiler: Types for all allocations #50337

merged 13 commits into from
Jul 31, 2023

Commits on Jul 29, 2023

  1. Allocation Profiler: Types for all allocations 

    Before this PR, we were missing the types for allocations in two cases:
1. allocations from codegen
2. allocations in gc_managed_realloc_

The second one is easy: those are always used for `buffer`s, right?

For the first one: we pass the type through to the allocation function,
so that we can log the allocation with the correct type.
    @NHDaly
    NHDaly committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    3dc95e3 View commit details
    Browse the repository at this point in the history

  2. Switch back to setting the type tag in LLVM IR, rather than in C. 

    The tradeoff here is:
- the compiler gets to see the set instruction and it can participate in optimization
- but the code size and compilation time of every allocation increases by 1 instruction.
    @NHDaly
    NHDaly committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    4c47804 View commit details
    Browse the repository at this point in the history

  3. Review suggestion: report (positive) delta in realloc

    @NHDaly
    NHDaly committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    8cd9a06 View commit details
    Browse the repository at this point in the history

  4. Update documentation for the Allocation Profiler; now we have all types 

    Add docs section on external profile visualizer tools
    @NHDaly
    NHDaly committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    736da48 View commit details
    Browse the repository at this point in the history

  5. First attempt at fixing llvm tests... 

    I frankly don't know enough to do this yet, I think.
    @NHDaly
    NHDaly committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    0de76b9 View commit details
    Browse the repository at this point in the history

  6. Docs suggestions 

    Co-authored-by: Valentin Churavy <[email protected]>
    @NHDaly @vchuravy
    NHDaly and vchuravy committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    f7e39c4 View commit details
    Browse the repository at this point in the history

  7. Now i know about the LLVM tests! 🎉

    @NHDaly
    NHDaly committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    c28f0ef View commit details
    Browse the repository at this point in the history

  8. Fix rest of the llvmpasses tests

    @NHDaly
    NHDaly committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    4a135a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. typo

    @NHDaly
    NHDaly committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    0c069d6 View commit details
    Browse the repository at this point in the history

  2. Fix jl_gc_alloc_typed from codegen. 

    This must never happen in any of the tests, other than this one llvm
unit test! :o
    @NHDaly
    NHDaly committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    a8691b1 View commit details
    Browse the repository at this point in the history

  3. PR Feedback: Add simpler example, and explain the in-depth example more.

    @NHDaly
    NHDaly authored Jul 30, 2023
    Configuration menu
    Copy the full SHA
    54a948d View commit details
    Browse the repository at this point in the history

  4. Update profile.md

    @NHDaly
    NHDaly authored Jul 30, 2023
    Configuration menu
    Copy the full SHA
    53be440 View commit details
    Browse the repository at this point in the history

  5. Update profile.md

    @NHDaly
    NHDaly authored Jul 30, 2023
    Configuration menu
    Copy the full SHA
    13d08c7 View commit details
    Browse the repository at this point in the history