-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use exchange in the hot path of the GC #50021
Conversation
does this make a noticeable difference in benchmarks? |
On a very simple benchmark just to illustrate. But this reproduces PR Master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems mergeable to me.
xchg
is a very expensive instruction when working with memory, on x86 (intel 11th gen) it has an implied lock and a latency of 19. A false positive here just means a slight amount of extra work so don't do that.