Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the package name to the LOAD_Pkgimage zone #49538

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

KristofferC
Copy link
Member

I couldn't figure out how to get the package name from within the function itself so I just passed it in from code loading instead.

It's nice to be able to see a list with the package names:

Screenshot 2023-04-27 at 12 16 04

Copy link
Member

@topolarity topolarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timing looks good - this is great metadata.

I'm not the right person to review the ABI change, so I'll leave Approval for someone else to take a look

test/precompile.jl Show resolved Hide resolved
@KristofferC KristofferC merged commit cc7fec7 into master Apr 28, 2023
@KristofferC KristofferC deleted the kc/pkgimage_prof branch April 28, 2023 13:01
fatteneder added a commit to fatteneder/PkgCacheInspector.jl that referenced this pull request May 12, 2024
- JuliaLang/julia#52123: Added the
  `int ignore_native` argument to jl_restore_package_image_from_file
- JuliaLang/julia#49538: Added the
  `const char *pkgname` argument to jl_restore_package_image_from_file
  and jl_restore_incremental.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants