Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps/tools: [msys2] Fix tar file creation #48859

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stahta01
Copy link
Contributor

@stahta01 stahta01 commented Mar 2, 2023

Add CREATE_TAR_FLAGS to avoid symbolic links under Windows build OS.

@stahta01 stahta01 marked this pull request as ready for review March 2, 2023 15:50
@inkydragon inkydragon added building Build system, or building Julia or its dependencies system:windows Affects only Windows labels Mar 4, 2023
@stahta01 stahta01 force-pushed the create_tar_fix branch 5 times, most recently from a1cac18 to 386ee94 Compare March 12, 2023 03:17
Add CREATE_TAR_FLAGS to avoid symbolic links under Windows build OS.
@tecosaur tecosaur added the awaiting review PR is complete and seems ready to merge. Has tests and news/compat if needed. CI failures unrelated. label Feb 15, 2024
@PallHaraldsson
Copy link
Contributor

PallHaraldsson commented Apr 10, 2024

Is this one done? Seems at least a simple fix, and please add the msys2 label (I incorrectly stated elsewhere "this it the only msys2 issue", I see that there are more, at least for improvement, not sure how many needed e.g. #44006).

@stahta01
Copy link
Contributor Author

This was the hardest fix for me to find. But, as I stated in the other issue; I no longer care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review PR is complete and seems ready to merge. Has tests and news/compat if needed. CI failures unrelated. building Build system, or building Julia or its dependencies system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants