abstractarray test: only test broken test on one iteration to reduce test report noise #48478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
added
test
This comment was marked as resolved.
This comment was marked as resolved.
IanButterworth
force-pushed
the
ib/abstractarray_test_ambiguity
branch
from
7174c73 to
7fd0f1f
Compare
IanButterworth
changed the title
|
I think this is minor and reasonable so I'll go ahead |
|
This makes sense. But now that I've look at it, I see that this is based on an old (pre-1.0) confusion in what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbauman
is it more appropriate to test that these are false, rather than marked as broken?Ok, I originally missed the explanation here #36405 (comment)
I think it makes sense to only test one iteration as
@test_broken.The motivator is that these account for 24806 tests marked as broken (the second most after ones fixed in #48465) which dwarfs the number of broken tests elsewhere.