Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RemoteLogger for distributed logging #48121

Closed
wants to merge 4 commits into from

Conversation

simonbyrne
Copy link
Contributor

Fixes JuliaLang/Distributed.jl#51

This is a pretty crude implementation: it simply remotecalls the logger on the main process, attaching a keyword pid to indicate which process triggered it, but I hope it can serve as a starting point.

The main downside of this approach is that it doesn't respect changes to the current logger on the main task, e.g.

with_logger(mylogger) do
   remotecall_wait(() -> @info("msg"), 2)
end

will still log to the global logger on the main process, not mylogger. This also means I can't test this using @test_logs. I don't see an easy way to fix this without something like #35757.

The other open question is when/where should the logger be instantiated?

@simonbyrne simonbyrne added parallelism Parallel or distributed computation logging The logging framework labels Jan 4, 2023
@simonbyrne
Copy link
Contributor Author

@c42f any thoughts?

@simonbyrne simonbyrne marked this pull request as ready for review January 10, 2023 23:50
@simonbyrne simonbyrne force-pushed the sb/distributed-logging branch from cafdce9 to e2990f8 Compare January 17, 2023 01:03
@simonbyrne
Copy link
Contributor Author

okay, added a test

@simonbyrne simonbyrne requested review from c42f and vchuravy January 17, 2023 01:29
@simonbyrne simonbyrne force-pushed the sb/distributed-logging branch from e2990f8 to 68a1681 Compare January 17, 2023 21:17
@ViralBShah
Copy link
Member

cc @tanmaykm

@simonbyrne
Copy link
Contributor Author

bump?

@vtjnash
Copy link
Member

vtjnash commented Feb 10, 2024

I didn't review, but now needs to be reopened at https://github.com/JuliaLang/Distributed.jl for JuliaLang/Distributed.jl#52

@vtjnash vtjnash closed this Feb 10, 2024
@vtjnash vtjnash deleted the sb/distributed-logging branch February 10, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging The logging framework parallelism Parallel or distributed computation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need better control over worker logging
3 participants