add RemoteLogger for distributed logging #48121
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JuliaLang/Distributed.jl#51
This is a pretty crude implementation: it simply
remotecall
s the logger on the main process, attaching a keywordpid
to indicate which process triggered it, but I hope it can serve as a starting point.The main downside of this approach is that it doesn't respect changes to the current logger on the main task, e.g.
will still log to the global logger on the main process, not
mylogger
. This also means I can't test this using@test_logs
. I don't see an easy way to fix this without something like #35757.The other open question is when/where should the logger be instantiated?