-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move safepoint emission to llvm-final-gc-lowering #47393
Conversation
|
OK I think at least this is needed, but it's not sufficient to fix the error:
|
The error means we are not running final lowering over a function |
Could we also not emit this for smallish functions? So something like On my computer I did some very rough testing and a function call + return takes about 1ns and the safepoint takes about 2ns so it's not nothing. |
Using
Looks like this is our first
We elimated the reference to |
7a42638
to
3ef7a67
Compare
@nanosoldier |
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
Maybe slightly nicer-form since we now emit them regularly,
and makes them slightly easier to handle for Enzyme.
cc: @wsmoses @d-netto