Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid timing race in async test #46941

Merged
merged 1 commit into from
Sep 29, 2022
Merged

avoid timing race in async test #46941

merged 1 commit into from
Sep 29, 2022

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Sep 28, 2022

This is the test from #27164.

The test was checking whether sleep(1) (which is started first) or sleep(0.05) (which is nominally shorter) returned first. Switch the order so that the short sleep should always end first.

Fixes #46360

test/misc.jl Show resolved Hide resolved
This is the test from #27164.

The test was checking whether sleep(1) (which is started first) or
sleep(0.05) (which is nominally shorter) returned first. Use an Event
instead so that they are explicitly ordered.

Fixes #46360
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Sep 29, 2022
@vtjnash vtjnash merged commit f346735 into master Sep 29, 2022
@vtjnash vtjnash deleted the jn/46360 branch September 29, 2022 18:52
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Intermittent failure in misc.jl 27164 test
3 participants