Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent info on isless and Base.isgreater #46632

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Consistent info on isless and Base.isgreater #46632

merged 1 commit into from
Sep 5, 2022

Conversation

udohjeremiah
Copy link
Contributor

help?> isless
search: isless disable_sigint islowercase

  isless(x, y)

  Values that are normally unordered, such as NaN, are ordered after
  regular values. missing values are ordered last.


help?> Base.isgreater
  isgreater(x, y)

  Defined with isless, this function is usually isless(y, x), but NaN
  and missing are ordered as smaller than any ordinary value with
  missing smaller than NaN.

isless says "are ordered after regular values". But then Base.isgreater says "are ordered as smaller than any ordinary value."

I believe the "regular" and "ordinary" are talking about same things, so its best if its stated as "regular" on both end.

@ViralBShah ViralBShah added the docs This change adds or pertains to documentation label Sep 5, 2022
@ViralBShah ViralBShah merged commit 9a7b118 into JuliaLang:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants