Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REPL] Meta-e: Don't execute the edited code when exiting editor #46153

Merged
merged 1 commit into from
Feb 13, 2023
Merged

[REPL] Meta-e: Don't execute the edited code when exiting editor #46153

merged 1 commit into from
Feb 13, 2023

Conversation

fredrikekre
Copy link
Member

@fredrikekre fredrikekre added the REPL Julia's REPL (Read Eval Print Loop) label Jul 24, 2022
@fredrikekre
Copy link
Member Author

Rebased and updated to restore the cursor if content was not modifed based on feedback from @KristofferC.

@KristofferC KristofferC added backport 1.9 Change should be backported to release-1.9 merge me PR is reviewed. Merge when all tests are passing labels Feb 13, 2023
@fredrikekre fredrikekre merged commit aaab409 into master Feb 13, 2023
@fredrikekre fredrikekre deleted the fe/editor branch February 13, 2023 16:23
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Feb 14, 2023
KristofferC pushed a commit that referenced this pull request Feb 20, 2023
@fredrikekre
[REPL] Meta-e: Don't execute the edited code when exiting editor (#46153
6213bb8 
)

(cherry picked from commit aaab409)
@KristofferC KristofferC mentioned this pull request Feb 20, 2023
Merged
50 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 6, 2023
@abelsiqueira abelsiqueira mentioned this pull request May 8, 2023
Merged
KristofferC pushed a commit that referenced this pull request Aug 14, 2023
@abelsiqueira
Correct info about Alt+e on 1.9 HISTORY.md (#49685)
7157029 
The code is not executed when existing the editor:
#46153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC Awaiting requested review from KristofferC

@rfourquet rfourquet Awaiting requested review from rfourquet

Assignees
No one assigned
Labels
REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredrikekre @giordano @KristofferC