[docs/base] add a type tree for Number
#45975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaLang#24741 Generated using the following code with manual modifications ```jl using AbstractTrees AbstractTrees.children(x::Type) = subtypes(x) print_tree(Number) ```
|
Can you add a blurb before the tree that describes what it shows? Does it make sense to also add an indication which ones are abstract types since the |
|
Any more comments? |
oscardssmith
reviewed
Aug 4, 2022
doc/src/base/numbers.md
Outdated
| @@ -2,6 +2,37 @@ | |||
|
|
|||
| ## Standard Numeric Types | |||
|
|
|||
| A type tree for all subtypes of `Number`. | |||
There was a problem hiding this comment.
can this "for included number types`"
|
Should we mark which types are primitive or struct types? Marking primitives seems noisy. Perhaps we should just mark struct types and indicate the rest are primitive types? The struct types according to
|
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #24741
Generated using the following code with manual modifications
AbstractIrrationalto the endpreview
