Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the deprecated download #45853

Closed
wants to merge 3 commits into from

Conversation

PallHaraldsson
Copy link
Contributor

No description provided.

@fredrikekre
Copy link
Member

There is no reason to do this before 2.0(?).

@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Jun 29, 2022

Maybe there's no reason to do this right now (I see it's part of "the API", exported from Base), is it allowed to change the API, in some 1.x, or is there only a syntax guarantee?

It might not be best to drop at the last minute for 1.8... but I'm still sure how far we would get with PkgEval. I think I made sure Julia itself will not fail (could be cleaned up better since it seems I can't drop files in the web interface of Github, and would need NEWS).

I would like to drop mbedTLS (and more), that's the main reason for this, see #43677 (comment) (since "we are underresourced in the security domain").

There's a very easy workaround for all users, use Downloads.download()

@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Jun 29, 2022

Maybe we don't actually need to drop download. It already uses package Download, I'm trying to figure out if we can drop mbedTLS, and it's unclear to me if used by Julia, as opposed to Download pkg, or Pkg.

@PallHaraldsson
Copy link
Contributor Author

Closing. This could have worked, except for some seeming minor issues: "Error: undefined binding 'Base.download' in @docs block in src/base/file.md:3-66"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants