Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully drop _tuple_any and improve type-based offset axes check. #45260

Merged
merged 7 commits into from
Aug 10, 2022
Merged

Fully drop _tuple_any and improve type-based offset axes check. #45260

merged 7 commits into from
Aug 10, 2022

Commits on Jul 25, 2022

  1. Follow up JuliaLang#45236, make length(::StepRange{Int8,Int128}) st… 

    …able
    @N5N3
    N5N3 committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    51e3d3c View commit details
    Browse the repository at this point in the history

  2. Fully drop _tuple_any 

    `_any_tuple` should be functionally consistent. (And has no bootstrap problem.)
    @N5N3
    N5N3 committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    1345994 View commit details
    Browse the repository at this point in the history

  3. Make sure has_offset_axes(::StepRange) could be const folded. 

    And define some "cheap" `firstindex`
    @N5N3
    N5N3 committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    ff7fee9 View commit details
    Browse the repository at this point in the history

  4. Do offset axes check on A's parent rather than itself. 

    This avoid some unneeded `axes` call, thus more possible be folded by the compiler.
    @N5N3
    N5N3 committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    1cb5f9d View commit details
    Browse the repository at this point in the history

  5. Some test move.

    @N5N3
    N5N3 committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    9b340c9 View commit details
    Browse the repository at this point in the history

  6. Code clean and make test work. 

    Co-Authored-By: Jameson Nash <[email protected]>
    @N5N3 @vtjnash
    N5N3 and vtjnash committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    dde6f0b View commit details
    Browse the repository at this point in the history

  7. Fix for length(::StepRange{T}) where T isa Union 

    And define `firstindex` accordingly.

Co-Authored-By: Jameson Nash <[email protected]>
    @N5N3 @vtjnash
    N5N3 and vtjnash committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    b1bb0a6 View commit details
    Browse the repository at this point in the history