AbstractInterpreter: remove method_table(::AbstractInterpreter, ::InferenceState) interface
#44389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/methodtable
branch
2 times, most recently
from
7332682
to
89afc0f
Compare
…InferenceState)` interface In #44240 we removed the `CachedMethodTable` support as it turned out to be ineffective under the current compiler infrastructure. Because of this, there is no strong reason to keep a method table per `InferenceState`. This commit simply removes the `method_table(::AbstractInterpreter, ::InferenceState)` interface and should make it clearer which interface should be overloaded to implement a contextual dispatch.
aviatesk
force-pushed
the
avi/methodtable
branch
from
89afc0f
to
c633182
Compare
|
@nanosoldier |
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. |
vtjnash
approved these changes
Mar 2, 2022
aviatesk
added a commit
to aviatesk/GPUCompiler.jl
that referenced
this pull request
Mar 3, 2022
JuliaLang/julia#44389 removed `method_table(::AbstractInterpreter, ::InferenceState)` interface, and now we should overload `method_table(::AbstractInterpreter)` instead.
aviatesk
added a commit
to aviatesk/GPUCompiler.jl
that referenced
this pull request
Mar 3, 2022
JuliaLang/julia#44389 removed `method_table(::AbstractInterpreter, ::InferenceState)` interface, and now we should overload `method_table(::AbstractInterpreter)` instead.
aviatesk
added a commit
to aviatesk/GPUCompiler.jl
that referenced
this pull request
Mar 3, 2022
JuliaLang/julia#44389 removed `method_table(::AbstractInterpreter, ::InferenceState)` interface, and now we should overload `method_table(::AbstractInterpreter)` instead.
aviatesk
added a commit
to aviatesk/GPUCompiler.jl
that referenced
this pull request
Mar 3, 2022
JuliaLang/julia#44389 removed `method_table(::AbstractInterpreter, ::InferenceState)` interface, and now we should overload `method_table(::AbstractInterpreter)` instead.
maleadt
pushed a commit
to JuliaGPU/GPUCompiler.jl
that referenced
this pull request
Mar 3, 2022
aviatesk
added a commit
to JuliaDebug/Cthulhu.jl
that referenced
this pull request
Mar 3, 2022
The `method_table` interface changed by that PR. Cthulhu doesn't need to overload it from the first place.
aviatesk
added a commit
to JuliaDebug/Cthulhu.jl
that referenced
this pull request
Mar 3, 2022
This was referenced Mar 4, 2022
aviatesk
added a commit
that referenced
this pull request
Mar 9, 2022
…InferenceState)` interface (#44389) In #44240 we removed the `CachedMethodTable` support as it turned out to be ineffective under the current compiler infrastructure. Because of this, there is no strong reason to keep a method table per `InferenceState`. This commit simply removes the `method_table(::AbstractInterpreter, ::InferenceState)` interface and should make it clearer which interface should be overloaded to implement a contextual dispatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #44240 we removed the
CachedMethodTablesupport as it turned out tobe ineffective under the current compiler infrastructure.
Because of this, there is no strong reason to keep a method table per
InferenceState.This commit simply removes the
method_table(::AbstractInterpreter, ::InferenceState)interface and should make it clearer which interface needs to be overloaded to
implement a contextual dispatch.