Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the sysimage.mk Makefile, set the JULIA_NUM_THREADS=1 environment variable when running the generate_precompile.jl script #44281

Merged
merged 1 commit into from
Feb 20, 2022
Merged

In the sysimage.mk Makefile, set the JULIA_NUM_THREADS=1 environment variable when running the generate_precompile.jl script #44281

merged 1 commit into from
Feb 20, 2022

Conversation

DilumAluthge
Copy link
Member

No description provided.

@DilumAluthge
In the sysimage.mk Makefile, set the JULIA_NUM_THREADS=1 environm…
0e0a07c 
…ent variable when running the `generate_precompile.jl` script
@DilumAluthge DilumAluthge added the building Build system, or building Julia or its dependencies label Feb 20, 2022
@DilumAluthge DilumAluthge requested a review from vtjnash February 20, 2022 05:57
@DilumAluthge
Copy link
Member Author

@vtjnash Can you double-check that my Makefile syntax is correct?

@IanButterworth
Copy link
Member

I think even with this, the other PR related to this #44252 may still be worth doing?

vtjnash
vtjnash approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. there is probably half a dozen ways to do this, but this way should work

@DilumAluthge DilumAluthge added the merge me PR is reviewed. Merge when all tests are passing label Feb 20, 2022
@DilumAluthge DilumAluthge merged commit e454858 into master Feb 20, 2022
@DilumAluthge DilumAluthge deleted the dpa/makefile-julia-num-threads branch February 20, 2022 09:20
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Feb 20, 2022
@IanButterworth IanButterworth mentioned this pull request Feb 20, 2022
Open
@IanButterworth IanButterworth added the backport 1.8 Change should be backported to release-1.8 label Feb 20, 2022
KristofferC pushed a commit that referenced this pull request Feb 23, 2022
@DilumAluthge
In the sysimage.mk Makefile, set the JULIA_NUM_THREADS=1 environm…
15977a0 
…ent variable when running the `generate_precompile.jl` script (#44281)

(cherry picked from commit e454858)
@KristofferC KristofferC mentioned this pull request Feb 23, 2022
Merged
33 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Feb 24, 2022
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this pull request Mar 2, 2022
@DilumAluthge @staticfloat
In the sysimage.mk Makefile, set the JULIA_NUM_THREADS=1 environm…
16cb90b 
…ent variable when running the `generate_precompile.jl` script (JuliaLang#44281)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@DilumAluthge @LilithHafner
In the sysimage.mk Makefile, set the JULIA_NUM_THREADS=1 environm…
3e174ca 
…ent variable when running the `generate_precompile.jl` script (JuliaLang#44281)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DilumAluthge @IanButterworth @vtjnash @KristofferC