fix UndefRefError for documentation system #44060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some smaller examples: julia> R=Base.Complex{<:Integer}
Complex{<:Integer}
help?> R
search: R Ref rm Real run rem REPL rpad repr reim real read rand Regex RawFD round retry reset read! range randn return rstrip rsplit rotr90
ERROR: UndefRefError: access to undefined reference
Stacktrace:
[1] getproperty
@ ./Base.jl:33 [inlined]
[2] summarize(io::IOBuffer, TT::Type, binding::Base.Docs.Binding)
@ REPL /data/vtjnash/julia/usr/share/julia/stdlib/v1.8/REPL/src/docview.jl:286
[3] summarize(binding::Base.Docs.Binding, sig::Type)
@ REPL /data/vtjnash/julia/usr/share/julia/stdlib/v1.8/REPL/src/docview.jl:249
[4] doc(binding::Base.Docs.Binding, sig::Type)
@ REPL /data/vtjnash/julia/usr/share/julia/stdlib/v1.8/REPL/src/docview.jl:182
[5] doc(binding::Base.Docs.Binding)
@ REPL /data/vtjnash/julia/usr/share/julia/stdlib/v1.8/REPL/src/docview.jl:160
[6] top-level scope
@ /data/vtjnash/julia/usr/share/julia/stdlib/v1.8/REPL/src/docview.jl:474
julia> REPL.summarize(devnull, Base.Complex{<:Integer}, REPL.Docs.Binding(Main, :Complex))
# Summary
```
struct Complex{var"#s1"<:Integer}
```
# Fields
```
ERROR: UndefRefError: access to undefined reference
Stacktrace:
[1] getproperty
@ ./Base.jl:33 [inlined]
[2] summarize(io::Base.TTY, TT::Type, binding::Base.Docs.Binding)
@ REPL /data/vtjnash/julia/usr/share/julia/stdlib/v1.8/REPL/src/docview.jl:286
[3] top-level scope
@ REPL[5]:1 |
vchuravy
approved these changes
Feb 15, 2022
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
Feb 17, 2022
* fix UndefRefError for documentation system * add a test Co-authored-by: Jameson Nash <[email protected]>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
* fix UndefRefError for documentation system * add a test Co-authored-by: Jameson Nash <[email protected]>
KristofferC
added a commit
that referenced
this pull request
Feb 23, 2022
* fix UndefRefError for documentation system * add a test Co-authored-by: Jameson Nash <[email protected]> (cherry picked from commit 4842007)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
* fix UndefRefError for documentation system * add a test Co-authored-by: Jameson Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44009 (#44009 (comment))
Haven't been able to make an MWE but confirmed with the examples in that issue.