-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add an example to the Base.prompt
docstring
#43638
Conversation
@DilumAluthge why does |
|
Can you add some context as to why? Just for my own understanding :) |
It just seems like a very short generic word that doesn't necessarily need to be exported. Plus I don't feel particular strongly though, so if other people really want to export |
My only argument is to have parity with Python (where you would use |
If, in the future, we do end up |
Perhaps also add |
Oh I didn't see #43637 |
I should explain my rationale for keeping this PR and #43637 separate. This PR (adding an example to the docstring) doesn't need a lot of discussion (and can be merged pretty quickly) because it doesn't change any guarantees about the public API. In contrast, #43637 makes |
No description provided.