backport fix float16(::Union{Float64,BigFloat}) #43092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
Nov 15, 2021
base/mpfr.jl
Outdated
| end | ||
| end | ||
| if (resi & 0x1fff == 0x1000) # if we are halfway between 2 Float16 values | ||
| This conversation was marked as resolved by vchuravy |
|
This seems to lack the tests from #42837, or? |
|
My thinking was that as a backport it is less important to have the test since people are very unlikely to change the implantation within 1.7, and this minimized size of the backport. Want me to add the tests? |
|
To me it seems just as important, since we are introducing new code into an environment where the code hasn't been run before and want to make sure all the functionality is valid there. The tests are always backported together with bug fixes. |
|
tests added. |
KristofferC
deleted the
oscardssmith-backport-fix-bigfloat-to-float16
branch
daviehh
pushed a commit
to daviehh/julia
that referenced
this pull request
Nov 16, 2021
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.