-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support libgit2 1.2 #42209
Closed
Closed
Support libgit2 1.2 #42209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libgit2 1.2 added a new remote_ready member to git_remote_callbacks, update RemoteCallbacks accordingly
Thanks. While you're at it, it would make sense to also use libgit2 1.2. That way we will use the latest version, and ensure that the new code works. |
I always build against system packages and am not familiar with updating bundled packages, someone else will have to take care of that. |
They don't for me without this patch (in 1.6.2)
|
Ah, thanks. Looks like #42310 used the old version from LibGit2_jll. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libgit2 1.2 added a new remote_ready member to git_remote_callbacks, update RemoteCallbacks accordingly