-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add paging to help> prompt ( #36460) #41423
base: master
Are you sure you want to change the base?
Conversation
I think this should be configurable somehow. |
@fredrikekre . would an environment variable similar to things like JULIA_WARN_COLOR et. al help here? But these values are set by |
Perhaps |
should I open a separate issue for this? It seems to be a bigger issue since it applies to all the REPL config including colors. |
Issue opened with some questions: #41435. |
Shouldn't we merge this while we make it more configurable? |
bump |
bumping again :) |
Adding a triage label to decide if we want this. I'm in favor. |
In general this is a good thing to have. First, I'm not sure this is the right place to implement it. It looks like this should move closer to the presentation layer (higher up the stack in the REPL)? Second, I have some issues with how the pager works. It would be nice if you didn't need to press an extra key when the output fits on one page. |
I also see some artifacts, for example I can get into this state easily:
|
I think that bug is an instance of #39198 (i.e. it is caused by the line containing the method signature, because it is longer than the TerminalMenu line width) |
Fixes #36460 .
Thanks