freebsd: Register JIT unwind info #39581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed in #39553 that JIT unwind info didn't actually work on FreeBSD. As a general policy, we should register our frame info to make sure that our unwind is accurate. Libunwind has some heuristics to fall back to, but they can break e.g. for large stack frames.
vtjnash
approved these changes
Feb 9, 2021
Sacha0
approved these changes
Feb 9, 2021
ararslan
approved these changes
Feb 9, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
I noticed in JuliaLang#39553 that JIT unwind info didn't actually work on FreeBSD. As a general policy, we should register our frame info to make sure that our unwind is accurate. Libunwind has some heuristics to fall back to, but they can break e.g. for large stack frames.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
I noticed in JuliaLang#39553 that JIT unwind info didn't actually work on FreeBSD. As a general policy, we should register our frame info to make sure that our unwind is accurate. Libunwind has some heuristics to fall back to, but they can break e.g. for large stack frames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in #39553 that JIT unwind info didn't actually
work on FreeBSD. As a general policy, we should register our frame info to make sure
that our unwind is accurate. Libunwind has some heuristics to fall back to, but they
can break e.g. for large stack frames.