Improve consistency of SONAME usage, fix debug installation #39009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SONAME and RPATH inconsistency resulted in `julia`/`julia-debug` occasionally being unable to find `libjulia.so`, due to `libjulia-internal` not having the right RPATH set (it was set to `$ORIGIN:$ORIGIN/julia`, when it now needs to be set to `$ORIGIN:$ORIGIN/..`). Use `patchelf` to address this during `make install`. We also want to use the SONAME of e.g. `libjulia` as much as possible, so as to avoid searching the filesystem for libraries that are already opened. Also fix a few bugs in building `julia-debug`.
|
@GunnarFarneback see if this fixes the issues you were having with |
This was referenced Dec 26, 2020
|
Should be backported? |
|
Yes, this solves the problem noted in #38950 (comment) on Ubuntu. |
|
I don't know if this covers all of the dlopen cases, but looks like it should help many cases. |
|
This(*) solved the macos failure for the DynamicallyLoadedEmbedding tests on nightly. Windows still remains broken though, https://github.com/GunnarFarneback/DynamicallyLoadedEmbedding.jl/runs/1616727928. (*) Or possibly some other PR of the last few days, but I guess this is the most likely one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONAME and RPATH inconsistency resulted in
julia/julia-debugoccasionally being unable to find
libjulia.so, due tolibjulia-internalnot having the right RPATH set (it was set to$ORIGIN:$ORIGIN/julia, when it now needs to be set to$ORIGIN:$ORIGIN/..). Usepatchelfto address this duringmake install.We also want to use the SONAME of e.g.
libjuliaas much as possible,so as to avoid searching the filesystem for libraries that are already
opened.
Also fix a few bugs in building
julia-debug.