-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix of [#38730], solarized colorscheme bug fix #38792
Conversation
end | ||
|
||
# filename, separator, line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@@ -30,6 +30,8 @@ answer_color() = text_colors[repl_color("JULIA_ANSWER_COLOR", default_color_answ | |||
stackframe_lineinfo_color() = repl_color("JULIA_STACKFRAME_LINEINFO_COLOR", :bold) | |||
stackframe_function_color() = repl_color("JULIA_STACKFRAME_FUNCTION_COLOR", :bold) | |||
|
|||
alt_light_black_color() = repl_color("JULIA_ALT_LIGHT_BLACK_COLOR", :light_black) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I like the "alt_light_black" name. Can we come up with a better name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely do not mind any other name, consider it as a placeholder.
Initially, I went with :stackframe_color
but then decided that :alt_light_black
is better.
Sorry for bumping this up. After I lived some time with this patch, it turns out that it doesn't solve all the problems.
As an alternative solution, maybe substitute |
As an alternative, one can redefine |
I think a general colorscheme mechanism that lets people remap the named colors in the terminal would be fine. Shouldn't be just |
I'll never finish this PR and it'll never be accepted in it's current form, so there is no need to keep it open. |
Fixes #38730
Add workaround of solarized scheme bug and expand
printstyled
functionality.