Try to avoid deadlock in Distributed test #38714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What I believe is happening here is that, since put! is a yield point, the remote call finishes and the async task gets run before the `wait` statement is reached, thus causing a deadlock. I don't have 100% proof that this is the issue, but I did see the test hanging during this test, so I figured it's worth a try. May help #38712 (particularly, the second of the linked test failures).
|
This doesn't seem to help :( |
|
I'm having some trouble debugging this. I guess #32283 might help. |
vtjnash
approved these changes
Dec 5, 2020
Keno
added a commit
that referenced
this pull request
Jun 5, 2024
What I believe is happening here is that, since put! is a yield point, the remote call finishes and the async task gets run before the `wait` statement is reached, thus causing a deadlock. I don't have 100% proof that this is the issue, but I did see the test hanging during this test, so I figured it's worth a try. May help #38712 (particularly, the second of the linked test failures).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I believe is happening here is that, since put! is a yield point, the remote call finishes
and the async task gets run before the
waitstatement is reached, thus causing a deadlock.I don't have 100% proof that this is the issue, but I did see the test hanging during this test,
so I figured it's worth a try. May help #38712 (particularly, the second of the linked test failures).