Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump NetworkOptions & Downloads (fix test log breakage) #38413

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

StefanKarpinski
Copy link
Member

@StefanKarpinski StefanKarpinski commented Nov 12, 2020

Includes JuliaLang/NetworkOptions.jl#3 which should help with test flakiness.

@StefanKarpinski
Copy link
Member Author

Well, Windows CI seems entirely borked. Not due to this change.

@StefanKarpinski
Copy link
Member Author

I'm not clear on whether I should retry these CI runs or not. The main reason for this PR is to improve CI, but it's hard to merge since CI is so flaky. Feels like a catch 22. cc @vtjnash, @staticfloat

@Keno Keno merged commit dc9ea8c into master Nov 13, 2020
@Keno Keno deleted the sk/bump-Downloads-NetworkOptions branch November 13, 2020 03:12
@Keno
Copy link
Member

Keno commented Nov 13, 2020

This does not show the CI failure it's supposed to fix, so I'll take it.

@staticfloat staticfloat restored the sk/bump-Downloads-NetworkOptions branch November 13, 2020 23:21
@martinholters martinholters deleted the sk/bump-Downloads-NetworkOptions branch November 16, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants