insert backtrace printing into user-facing JL_CATCH #38201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Oct 27, 2020
|
Yeah on windows the output get's mangled. |
|
True, I guess it's not good to intermix writes to JL_STDERR with STDERR_FILENO |
vchuravy
commented
Oct 28, 2020
Since `jlbacktrace` uses `STDERR_FILENO` directly we have to be a bit careful to avoid mangled errors (particularily on Windows), so we use `STDERR_FILENO` directly, when also using `jlbacktrace`.
vchuravy
force-pushed
the
vc/backtraces
branch
from
a068497
to
3c33910
Compare
c42f
reviewed
Oct 29, 2020
| @@ -492,6 +492,9 @@ static int exec_program(char *program) | |||
| jl_load(jl_main_module, program); | |||
| } | |||
| JL_CATCH { | |||
| // TODO: It is possible for this output | |||
| // to be mangled due to `jlbacktrace` | |||
| // printing directly to STDERR_FILENO. | |||
There was a problem hiding this comment.
Is it possible to resolve this as you've done elsewhere then?
There was a problem hiding this comment.
It wasn't immediately clear to me how to do so. The code mixes JL_STDERR and jl_stderr_objs and I presume it does so for a reason. I am not sure if it is gurantueed that hose two streams will be the same.
Some git archeology shows that this is code from the ancient times.
There was a problem hiding this comment.
Oh yes I see. So it seems that errs could certainly be pointing to some other stream if redirect_stderr was called. I think the fix here, in principle, is to have some shim to call display_error() rather than printing the current exception and backtrace separately. If display_error doesn't exist or fails, then the fallback path of shown_err == 0 would be taken.
KristofferC
pushed a commit
that referenced
this pull request
Nov 2, 2020
insert backtrace printing into user-facing JL_CATCH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #38134 (comment) I found it impossible to tell
which finalizer is to blame. With this a stacktrace is being printed:
In this example the finalizer is
#9 at ./REPL[4]:11