-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug when inlining pending nodes #37634
Conversation
While working on IR, we give pending nodes SSA ids after the main body of the function, and then we drop them in place during compaction. Inlining was using thse IDs to try to determine which basic block we're currently inlining into, but for pending blocks it was looking at the raw ID rather than the insertion position, corrupting the CFG. Fixes #37555 Fixes #37182
c2eef6a
to
ace08d8
Compare
@nanosoldier |
Your package evaluation job has completed - possible issues were detected. A full report can be found here. cc @maleadt |
Well I should have triggered a vs build to see the improvments, but non of the fails look like the reported issue. |
any chance this could be backported to 1.5? happy to make a PR |
I've added the backport label, so this should be included the next 1.5.x release. |
Doesn't backport cleanly. Can push a backported commit to #38122 |
The PR that this fixed a bug in is not part of 1.5 |
While working on IR, we give pending nodes SSA ids after the main
body of the function, and then we drop them in place during compaction.
Inlining was using thse IDs to try to determine which basic block
we're currently inlining into, but for pending blocks it was looking
at the raw ID rather than the insertion position, corrupting the CFG.
Fixes #37555
Fixes #37182