Improve inference for unique with abstract eltypes
#36280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
added
compiler:latency
#20317 improved inference of unique, but problematic cases still arise for containers with known but abstract eltypes. Here, we short-circuit the `typejoin` when the return type is determined by the element type of the input container. For `unique(f, itr)`, this commit also allows the caller to supply `seen::Set` to circumvent the inference challenges.
timholy
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Jun 30, 2020
JuliaLang/julia#36280 introduced the ability to pre-allocate the container used to track values of `f.(itr)` in `unique(f, itr)`. Particularly for containers with `Union` elements, this circumvents significant inference problems. Related: JuliaLang/julia#36454
timholy
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Jun 30, 2020
JuliaLang/julia#36280 introduced the ability to pre-allocate the container used to track values of `f.(itr)` in `unique(f, itr)`. Particularly for containers with `Union` elements, this circumvents significant inference problems. Related: JuliaLang/julia#36454
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
JuliaLang#20317 improved inference of unique, but problematic cases still arise for containers with known but abstract eltypes. Here, we short-circuit the `typejoin` when the return type is determined by the element type of the input container. For `unique(f, itr)`, this commit also allows the caller to supply `seen::Set` to circumvent the inference challenges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20317 improved inference of
unique, but problematic cases still arise for containers with known but abstract eltypes. Here, we short-circuit thetypejoinwhen the return type is determined by the element type of the input container.For
unique(f, itr), this commit also allows the caller to supplyseen::Setto circumvent the inference challenges.This resolves a number of invalidations in
PkgandREPL.TODO: update NEWS entry with issue number, once assigned.