Split show_ir so line printer can be used elsewhere
#35952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently JuliaInterpreter & Debugger need to print just a subset of CodeInfo statements (those surrounding the current program counter). Currently they print the whole thing to an IOBuffer, split the lines, and keep just a subset. Unfortunately, because some statements print over multiple lines, it's easy to get misaligned. This makes it possible to call the standard printer for a specified line.
|
You can see a preview of some of the kinds of display that are possible at https://juliadebug.github.io/LoweredCodeUtils.jl/previews/PR30/edges/. Since this seems fairly noninvasive, and I've written it into the docs for an important Revise update (one that will improve experience for all of Julia 1.x, not just 1.6), I plan to merge this soon. |
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
Currently JuliaInterpreter & Debugger need to print just a subset of CodeInfo statements (those surrounding the current program counter). Currently they print the whole thing to an IOBuffer, split the lines, and keep just a subset. Unfortunately, because some statements print over multiple lines, it's easy to get misaligned. This makes it possible to call the standard printer for a specified line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaInterpreter & Debugger need to print just a subset of CodeInfo statements (those surrounding the current program counter). Currently they print the whole thing to an IOBuffer, split the lines, and keep just a subset. Unfortunately, because some statements print over multiple lines, it's easy to get misaligned.
This makes it possible to call the standard printer for a specified line.
Compared to the previous implementation, this does do a little bit of redundant work on each statement (recomputation of
max_bb_idx_sizeandmaxlength_idx), but that's <100ns of work so I don't think it's that big a deal. Alternatively I could add them as arguments.