Add norm kwarg to isapprox
#35883
Merged
Add norm kwarg to isapprox
#35883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloede
force-pushed
the
add-norm-kwarg-to-isapprox
branch
from
54a0190
to
abcb76e
Compare
stevengj
reviewed
May 14, 2020
|
This seems is fine to me. I guess it is useful for generic programming, e.g. if you want to pass an L1 norm for array arguments but don't want to special-case numeric arguments. |
|
Needs a NEWS item. |
|
Would something like be appropriate (added under |
sloede
force-pushed
the
add-norm-kwarg-to-isapprox
branch
from
8080688
to
d3fd706
Compare
|
I added the NEWS item & did a rebase. Thank you for your feedback! |
stevengj
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (hopefully) fixes #13132.