Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export jl_resolve_globals_in_ir in Julia src #32902

Merged
merged 10 commits into from
Oct 3, 2019
Merged

Export jl_resolve_globals_in_ir in Julia src #32902

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ff20963
Export jl_resolve_globals_in_ir in Julia src
NHDaly Jul 8, 2019
71a356b
Export new `jl_expand_and_resolve`, instead of jl_resolve_globals_in_ir.
NHDaly Aug 23, 2019
3d9feac
Comment `lower_and_resolve_lambda`
NHDaly Sep 3, 2019
94285d8
Remove the exposed Julia binding for ccall(:jl_expand_and_resolve), b…
NHDaly Sep 12, 2019
52cbcfa
Merge branch 'master' into export_jl_resolve_globals_in_ir
NHDaly Sep 12, 2019
7b75d1e
Merge branch 'master' into export_jl_resolve_globals_in_ir
NHDaly Sep 13, 2019
e743a6e
Merge branch 'master' into export_jl_resolve_globals_in_ir
NHDaly Sep 18, 2019
a27b454
Restore error states to what it was before this PR: aways error if !i…
NHDaly Sep 18, 2019
b08231f
Add error return value semantics to comment on jl_expand_and_resolve
NHDaly Oct 2, 2019
6a22b25
Add GC annotations inside `jl_expand_and_resolve`
NHDaly Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/julia_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,10 @@ void jl_log(int level, jl_value_t *module, jl_value_t *group, jl_value_t *id,

int isabspath(const char *in);

// TODO(NHDALY): Find the right spot for this.
JL_DLLEXPORT void jl_resolve_globals_in_ir(jl_array_t *stmts, jl_module_t *m,
jl_svec_t *sparam_vals, int binding_effects);
NHDaly marked this conversation as resolved.
Show resolved Hide resolved

extern jl_sym_t *call_sym; extern jl_sym_t *invoke_sym;
extern jl_sym_t *empty_sym; extern jl_sym_t *top_sym;
extern jl_sym_t *module_sym; extern jl_sym_t *slot_sym;
Expand Down
4 changes: 2 additions & 2 deletions src/method.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ static jl_value_t *resolve_globals(jl_value_t *expr, jl_module_t *module, jl_sve
return expr;
}

void jl_resolve_globals_in_ir(jl_array_t *stmts, jl_module_t *m, jl_svec_t *sparam_vals,
int binding_effects)
JL_DLLEXPORT void jl_resolve_globals_in_ir(jl_array_t *stmts, jl_module_t *m,
jl_svec_t *sparam_vals, int binding_effects)
NHDaly marked this conversation as resolved.
Show resolved Hide resolved
{
size_t i, l = jl_array_len(stmts);
for (i = 0; i < l; i++) {
Expand Down