-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade doc/make.jl
to introspect branch/tag names from git info
#32823
Conversation
Note that this requires that the julia you're using to deploy the docs matches the current julia checkout.
Also needs |
What happens if |
It won't deploy. If we already check for PRs, then The only minor this is that |
# encode things like branch, whether it's built on a tag, etc.... | ||
env_mappings = [ | ||
"TRAVIS_REPO_SLUG" => "JuliaLang/docs.julialang.org", | ||
"TRAVIS_BRANCH" => Base.GIT_VERSION_INFO.branch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"TRAVIS_BRANCH" => Base.GIT_VERSION_INFO.branch, | |
"TRAVIS_BRANCH" => Base.GIT_VERSION_INFO.branch, | |
"TRAVIS_PULL_REQUEST" => "false", |
Ah, I see. In that case, let's set |
I'm going to merge this, then we'll see if the build on |
Upgrade `doc/make.jl` to introspect branch/tag names from git info (cherry picked from commit ad8cf8d)
Note that this requires that the julia you're using to deploy the docs matches the current julia checkout.