Don't attempt to const prop call cycles #31996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, probably. I am slightly concerned about these cases preventing inlining results (or even things like inferring nothrow). |
Even if the result is unused. Fixes #31974.
|
I think it's unlikely to be possible to inline these (or at least, requires an entirely different fixed point or tail-call algorithm) |
|
Yes, for an actual call cycle agreed, but it'd be nice to infer |
|
👍 Makes sense to me. Should we go even further and never constant prop unused calls? |
Maybe in the future, but for now we do need this because we want to look it up during inlining. Additionally, we could always discover a value-dependent guaranteed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the result is unused. Fixes #31974.