Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pop_exception lowering for try-break-finally (#31766) #31931

Merged
merged 1 commit into from
May 9, 2019
Merged

Fix pop_exception lowering for try-break-finally (#31766) #31931

merged 1 commit into from
May 9, 2019

Conversation

c42f
Copy link
Member

@c42f c42f commented May 5, 2019

In the case where a finally handler was active, pop_exception was
incorrectly omitted when lowering break inside a catch block. This
leads to stale exceptions on the stack.

Fix #31766

@c42f
Fix pop_exception lowering for try-break-finally (#31766)
f49b3f9 
In the case where a finally handler was active, pop_exception was
incorrectly omitted when lowering `break` inside a catch block. This
leads to stale exceptions on the stack.
@c42f c42f requested a review from vtjnash May 5, 2019 23:24
@c42f c42f modified the milestone: 1.2 May 7, 2019
@c42f c42f mentioned this pull request May 8, 2019
Closed
@c42f c42f added bugfix This change fixes an existing bug error handling Handling of exceptions by Julia or the user labels May 8, 2019
@KristofferC KristofferC mentioned this pull request May 9, 2019
Closed
58 tasks
@JeffBezanson JeffBezanson added the compiler:lowering Syntax lowering (compiler front end, 2nd stage) label May 9, 2019
@JeffBezanson JeffBezanson merged commit 829a4a6 into master May 9, 2019
@JeffBezanson JeffBezanson deleted the cjf/excstack-fix-break-finally branch May 9, 2019 22:10
@vtjnash
Copy link
Member

vtjnash commented May 10, 2019

❤️

KristofferC pushed a commit that referenced this pull request May 13, 2019
@c42f @KristofferC
Fix pop_exception lowering for try-break-finally (#31766) (#31931)
2c2b344 
In the case where a finally handler was active, pop_exception was
incorrectly omitted when lowering `break` inside a catch block. This
leads to stale exceptions on the stack.

(cherry picked from commit 829a4a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug compiler:lowering Syntax lowering (compiler front end, 2nd stage) error handling Handling of exceptions by Julia or the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

try/catch/break/finally doesn't reset exception stack
4 participants
@c42f @vtjnash @JeffBezanson @KristofferC