Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Singleton Types H4 -> H3 #30717

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Singleton Types H4 -> H3 #30717

merged 1 commit into from
Jan 15, 2019

Conversation

lostella
Copy link
Contributor

It's not apparent to me why this section should have an H4 header, which makes it look like a subsection of "Named Tuple Types". Making it H3.

@lostella
Singleton Types H4 -> H3
0dba17b 
It's not apparent to me why this section should have an H4 header, which makes it look like a subsection of "Named Tuple Types". Making it H3.
@fredrikekre fredrikekre added docs This change adds or pertains to documentation backport pending 1.0 labels Jan 15, 2019
fredrikekre
fredrikekre approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and welcome as a contributor to Julia.

@fredrikekre fredrikekre merged commit 384eb30 into JuliaLang:master Jan 15, 2019
@StefanKarpinski
Copy link
Member

It's not apparent to me why this section should have an H4 header

IIRC, it used to be a subsection of another H3 header where it actually made sense as a subsection. Doesn't seem to make much sense anymore. Thanks for the contribution!

KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@lostella @KristofferC
doc: update "Singleton Types" section header from H4 -> H3 (#30717)
6bc6e9a 
(cherry picked from commit 384eb30)
@KristofferC KristofferC mentioned this pull request Feb 11, 2019
Merged
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lostella @StefanKarpinski @fredrikekre @JeffBezanson