Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for Profile.init() and callers error #30711

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Tests for Profile.init() and callers error #30711

merged 1 commit into from
Jan 16, 2019

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Jan 13, 2019

Going by coverage these are missing...

@kshyatt kshyatt added the test This change adds or pertains to unit tests label Jan 13, 2019
@kshyatt kshyatt requested a review from JeffBezanson January 13, 2019 19:02
@kshyatt kshyatt force-pushed the ksh/profile branch 2 times, most recently from c18cc09 to c2610b4 Compare January 15, 2019 13:54
@kshyatt
Copy link
Contributor Author

kshyatt commented Jan 15, 2019

OK! Finally passing :p. Looks like we had an AV timeout...

@kshyatt kshyatt requested a review from vtjnash January 16, 2019 19:54
@fredrikekre fredrikekre merged commit f10cf03 into master Jan 16, 2019
@fredrikekre fredrikekre deleted the ksh/profile branch January 16, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson approved these changes

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kshyatt @JeffBezanson @fredrikekre