Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
signed(T)
,unsigned(T)
. #30445Add
signed(T)
,unsigned(T)
. #30445Changes from all commits
1a5a012
64e0bde
eab2d54
6a34de1
4af0d13
81ae5ec
3a6339c
fabe5b0
6f62176
8369cfe
367f744
b934adf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed all these tests to be
===
from==
, because they would be equal even ifsigned()
did nothing. Lemme know if you don't like that! :)Also, I was a bit confused by the
@test_throws
here. I clarified its behavior with this# Note
, but maybe it's better to fix/clarify the test itself? I'm not reallly sure what it's testing though, unfortunately.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand that test either. Does
git blame
shed any light?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the test was added here: #11962, during
v0.4.0
.Maybe the behavior was different back then, or maybe it was a mistake? (It was David's first PR ever after all! 😋) I'm happy to either remove the whole line or just leave the comment; whatever you prefer!